Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with report not appearing #199

Merged
merged 1 commit into from
Jan 18, 2023
Merged

Fix bug with report not appearing #199

merged 1 commit into from
Jan 18, 2023

Conversation

stavros11
Copy link
Member

@stavros11 stavros11 commented Jan 17, 2023

The report (index.html) is not properly rendered after a run is finished. This PR should fix this issue.

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@stavros11 stavros11 added the bug Something isn't working label Jan 17, 2023
@stavros11 stavros11 self-assigned this Jan 17, 2023
@codecov
Copy link

codecov bot commented Jan 17, 2023

Codecov Report

Merging #199 (f157bef) into main (e74a842) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #199   +/-   ##
=======================================
  Coverage   36.07%   36.07%           
=======================================
  Files          19       19           
  Lines        1192     1192           
=======================================
  Hits          430      430           
  Misses        762      762           
Flag Coverage Δ
unittests 36.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/qibocal/web/report.py 0.00% <ø> (ø)

Copy link
Contributor

@andrea-pasquale andrea-pasquale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stavros11.
It works for me.

@andrea-pasquale andrea-pasquale merged commit e4c7eaa into main Jan 18, 2023
@andrea-pasquale andrea-pasquale deleted the reportfix branch January 18, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants