Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix allXY plot label and plot #221

Merged
merged 1 commit into from
Jan 25, 2023
Merged

Fix allXY plot label and plot #221

merged 1 commit into from
Jan 25, 2023

Conversation

andrea-pasquale
Copy link
Contributor

@andrea-pasquale andrea-pasquale commented Jan 25, 2023

After merging #189 I changed the allXY routines because I thought that in the y axis we were supposed to plot the probability of the ground state (I got confused by the label in the plot). This PR fixes this issue.
Moreover, I changed the y label of the plot to "Expectation value of Z" to avoid future misunderstandings.

image

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@andrea-pasquale andrea-pasquale added the bug Something isn't working label Jan 25, 2023
@andrea-pasquale andrea-pasquale added this to the Qibocal 0.0.1 milestone Jan 25, 2023
@andrea-pasquale andrea-pasquale self-assigned this Jan 25, 2023
@codecov
Copy link

codecov bot commented Jan 25, 2023

Codecov Report

Merging #221 (e58e3c2) into minor_fix_multiplex (73dcffe) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           minor_fix_multiplex     #221      +/-   ##
=======================================================
- Coverage                37.13%   37.08%   -0.06%     
=======================================================
  Files                       19       19              
  Lines                     1349     1351       +2     
=======================================================
  Hits                       501      501              
- Misses                     848      850       +2     
Flag Coverage Δ
unittests 37.08% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/qibocal/plots/allXY.py 11.90% <0.00%> (-0.30%) ⬇️

Copy link
Member

@stavros11 stavros11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merged this in my branch and it works, thanks.

@scarrazza scarrazza merged commit 857b922 into minor_fix_multiplex Jan 25, 2023
@scarrazza scarrazza deleted the fix_allXY branch January 25, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants