Removing precision sweep #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #270 +/- ##
==========================================
+ Coverage 44.02% 44.17% +0.14%
==========================================
Files 28 28
Lines 1774 1768 -6
==========================================
Hits 781 781
+ Misses 993 987 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
stavros11
reviewed
Mar 9, 2023
Comment on lines
16
to
17
| width: int, | ||
| step: int, |
There was a problem hiding this comment.
That is fine with me, but maybe something like
Suggested change
| width: int, | |
| step: int, | |
| frequency_width: int, | |
| frequency_step: int, |
would be clearer, so that we know what we sweep?
There was a problem hiding this comment.
Or maybe freq_width so that it is in agreement with resonator_punchout etc.
There was a problem hiding this comment.
I agree. I think that freq_width is fine.
4 tasks
aorgazf
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #268.
Checklist: