Tree routines #290
Merged
Tree routines #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
19 tasks
…nto tree_routines
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
… and platform.update()
…nto tree_routines
|
@Edoardo-Pedicillo @DavidSarlle if we are happy with the current status of this PR we could merge it to #279. |
|
@andrea-pasquale from the point of view of the code it is ok from me. On the other hand, I am still debugging the results obtained from some routines with qblox to be sure that they are correct after all the changes introduced in the driver and qibocal. But I can do it from #279 . You can see the status of tests here: qiboteam/qibolab#370. |
DavidSarlle
approved these changes
Apr 19, 2023
…nto tree_routines
|
we can merge it |
|
Thanks @DavidSarlle and @Edoardo-Pedicillo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a summary of the status of all the routines.
Checklist: