Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable simulation in autocalibration layout #315

Merged
merged 6 commits into from
May 1, 2023

Conversation

andrea-pasquale
Copy link
Contributor

This PR implements some features needed to make the autocalibration layout more flexible including:

  • Define routines which involve only simulation without raising errors
  • Make qubits, format and platform parameters optional in the new runcard
  • If qubits is not provided the report will generate a single plot

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

Copy link
Contributor

@Edoardo-Pedicillo Edoardo-Pedicillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank @andrea-pasquale, only one small comment.

src/qibocal/auto/operation.py Show resolved Hide resolved
@Edoardo-Pedicillo Edoardo-Pedicillo self-requested a review May 1, 2023 06:45
@andrea-pasquale andrea-pasquale merged commit 5a22a83 into split_data_fit May 1, 2023
@andrea-pasquale andrea-pasquale deleted the dummy_routine branch May 1, 2023 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants