Tests and docstrings for autocalibration #319
Conversation
|
I did not review thoroughly, just wanted to say good job for adding the test and nice to see that it's so compact! 👏 |
tests/test_operations.py
Outdated
| def test_data_acquisition(action): | ||
| """Test data acquisition for all routines using dummy""" | ||
| task = Task(action) | ||
| print(task) |
There was a problem hiding this comment.
This is probably for debugging, just remember to remove.
There was a problem hiding this comment.
Oh yes thank you.
Actually I wanted to check because even with the dummy platform some routines (especially allXY) may take a very long time due to qiboteam/qibolab#323.
Maybe there is a better way to do it. For the time being I'm just putting everything in a runcard :) |
Co-authored-by: Edoardo-Pedicillo <[email protected]>
for more information, see https://pre-commit.ci
|
@stavros11 let me know if you want to have a look at tests directly in this PR. |
This PR implements tests and docstrings for all the calibration routines used for autocalibration.
Tests are currently performed with the dummy platform.
Tests are passing locally but they will fail here because we should use qiboteam/qibolab#341
Checklist: