Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore dummy platform #370

Merged
merged 6 commits into from
Jun 1, 2023
Merged

Restore dummy platform #370

merged 6 commits into from
Jun 1, 2023

Conversation

andrea-pasquale
Copy link
Contributor

@andrea-pasquale andrea-pasquale commented May 30, 2023

This PR works with qiboteam/qibolab#460.
I've updated the lock file so tests should pass (hopefully).

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Merging #370 (5c1a6f4) into main (0785bb0) will increase coverage by 11.16%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #370       +/-   ##
===========================================
+ Coverage   42.96%   54.12%   +11.16%     
===========================================
  Files          68       68               
  Lines        5367     5367               
===========================================
+ Hits         2306     2905      +599     
+ Misses       3061     2462      -599     
Flag Coverage Δ
unittests 54.12% <ø> (+11.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 25 files with indirect coverage changes

Copy link
Member

@stavros11 stavros11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks.

@andrea-pasquale andrea-pasquale merged commit 29e3c0e into main Jun 1, 2023
@andrea-pasquale andrea-pasquale deleted the restore_dummy branch June 1, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants