Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ro_amplitude as a parameter for tof #418

Merged
merged 3 commits into from
Jun 26, 2023
Merged

ro_amplitude as a parameter for tof #418

merged 3 commits into from
Jun 26, 2023

Conversation

Jacfomg
Copy link
Contributor

@Jacfomg Jacfomg commented Jun 26, 2023

Forgot I also added the ro_amplitude as a parameter

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #418 (1aa5678) into main (ae6d2ce) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #418   +/-   ##
=======================================
  Coverage   96.73%   96.73%           
=======================================
  Files          48       48           
  Lines        3089     3093    +4     
=======================================
+ Hits         2988     2992    +4     
  Misses        101      101           
Flag Coverage Δ
unittests 96.73% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ation/signal_experiments/time_of_flight_readout.py 100.00% <100.00%> (ø)

@Jacfomg Jacfomg added this pull request to the merge queue Jun 26, 2023
Merged via the queue into main with commit 8d2b630 Jun 26, 2023
@Jacfomg Jacfomg deleted the tof2 branch June 26, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants