Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plot nicely when punchout fitting fails #421

Merged
merged 1 commit into from
Jul 3, 2023
Merged

Conversation

Jacfomg
Copy link
Contributor

@Jacfomg Jacfomg commented Jul 1, 2023

Plot nicely when punchout fitting fails by removing the failed point from the plot at (0,0)

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@codecov
Copy link

codecov bot commented Jul 1, 2023

Codecov Report

Merging #421 (4f9387c) into main (e251c80) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #421   +/-   ##
=======================================
  Coverage   96.77%   96.77%           
=======================================
  Files          48       48           
  Lines        3128     3129    +1     
=======================================
+ Hits         3027     3028    +1     
  Misses        101      101           
Flag Coverage Δ
unittests 96.77% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...l/protocols/characterization/resonator_punchout.py 96.42% <100.00%> (+0.02%) ⬆️

Copy link
Contributor

@andrea-pasquale andrea-pasquale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the proposal @Jacfomg.
I think that this PR might be not necessary after we merge #413, since it will remove the try except block for the punchout. Lets see which PR gets merged first.

@github-merge-queue github-merge-queue bot merged commit 4f9387c into main Jul 3, 2023
@andrea-pasquale
Copy link
Contributor

By merging #423 I accidentally merged also this one.
I guess that it is fine. @Edoardo-Pedicillo can take care of the changes in #413.

@scarrazza scarrazza deleted the punchout-fitting branch August 2, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants