Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double backend allocation #431

Merged
merged 6 commits into from
Jul 6, 2023
Merged

Fix double backend allocation #431

merged 6 commits into from
Jul 6, 2023

Conversation

andrea-pasquale
Copy link
Contributor

@andrea-pasquale andrea-pasquale commented Jul 6, 2023

Closes #428.

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@andrea-pasquale andrea-pasquale added the bug Something isn't working label Jul 6, 2023
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #431 (713cf88) into main (eca7526) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #431   +/-   ##
=======================================
  Coverage   96.77%   96.77%           
=======================================
  Files          48       48           
  Lines        3129     3129           
=======================================
  Hits         3028     3028           
  Misses        101      101           
Flag Coverage Δ
unittests 96.77% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/qibocal/auto/runcard.py 97.82% <100.00%> (ø)
...cal/protocols/characterization/dispersive_shift.py 100.00% <100.00%> (ø)

Comment on lines +58 to +59
GlobalBackend.set_backend(self.backend, self.platform)
return GlobalBackend()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After merging #432 here. Things might be confusing.
This is the fix for #428.

Copy link
Member

@stavros11 stavros11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks.

@andrea-pasquale andrea-pasquale merged commit 0bdd257 into main Jul 6, 2023
@andrea-pasquale andrea-pasquale deleted the fix_backend branch July 6, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Platform instantiated twice
2 participants