Readout characterization #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrea-pasquale
requested changes
Jul 10, 2023
There was a problem hiding this comment.
Thanks @Jacfomg. I tested the routine on hardware and it works.
I have some suggestions, mainly moving the computation of the fidelity and QNDness from the plot to the fit and some general improvements.
src/qibocal/protocols/characterization/readout_characterization.py
Outdated
Show resolved
Hide resolved
src/qibocal/protocols/characterization/readout_characterization.py
Outdated
Show resolved
Hide resolved
src/qibocal/protocols/characterization/readout_characterization.py
Outdated
Show resolved
Hide resolved
src/qibocal/protocols/characterization/readout_characterization.py
Outdated
Show resolved
Hide resolved
| """Store output for single qubit.""" | ||
| ar = np.empty(probability.shape, dtype=ReadoutCharacterizationType) | ||
| ar["probability"] = probability | ||
| self.data[qubit, state, number_readout] = np.rec.array(ar) |
There was a problem hiding this comment.
As in the other PR maybe we can drop the number_readout considering that the number_readout is just the row of the array.
There was a problem hiding this comment.
I think in this case they are separate arrays.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #435 +/- ##
==========================================
+ Coverage 97.15% 97.24% +0.09%
==========================================
Files 49 50 +1
Lines 3233 3341 +108
==========================================
+ Hits 3141 3249 +108
Misses 92 92
Flags with carried forward coverage won't be shown. Click here to find out more.
|
andrea-pasquale
approved these changes
Jul 24, 2023
Edoardo-Pedicillo
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per https://arxiv.org/abs/2106.06173. Calculate Fidelity and QND-ness of our readout.
Works with qiboteam/qibolab#517
Checklist: