-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement flux crosstalk matrix #462
Conversation
Codecov Report
@@ Coverage Diff @@
## main #462 +/- ##
==========================================
+ Coverage 95.95% 96.01% +0.06%
==========================================
Files 61 61
Lines 4421 4489 +68
==========================================
+ Hits 4242 4310 +68
Misses 179 179
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @stavros11, generally it looks good to me.
You can find below a few comments.
Just a tiny remark. The colormaps tend to overlap when you use more than one flux qubit.
I think that it should be possible to separate the color maps.
src/qibocal/protocols/characterization/flux_dependence/qubit_flux_dependence.py
Outdated
Show resolved
Hide resolved
src/qibocal/protocols/characterization/flux_dependence/utils.py
Outdated
Show resolved
Hide resolved
src/qibocal/protocols/characterization/flux_dependence/qubit_flux_dependence.py
Outdated
Show resolved
Hide resolved
src/qibocal/protocols/characterization/flux_dependence/qubit_flux_dependence.py
Outdated
Show resolved
Hide resolved
Thanks for the review @andrea-pasquale. I fixed your comments and removed the phase from the plots in order to have the matrix structure, as discussed in a previous meetings. I also implemented the crosstalk matrix for the resonator spectroscopy routine since this was also a TODO. Note that I disabled the colorbar from the matrix plots because I was unable to properly align it in the general case (because the columns of the matrix depends on Other than that, this should be ready. I am not sure why the tests/coverage are failing in the CI but doesn't seem related to this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @stavros11.
After relaunching the jobs the CI seems to work.
I have a few small suggestions.
I guess that the first step will be to perform also a post-processing in order to compute the cross-talk matrix. We can do it in a separate. I like already the possibility of visualizing the cross-talk in this way.
src/qibocal/protocols/characterization/flux_dependence/utils.py
Outdated
Show resolved
Hide resolved
src/qibocal/protocols/characterization/flux_dependence/utils.py
Outdated
Show resolved
Hide resolved
src/qibocal/protocols/characterization/flux_dependence/utils.py
Outdated
Show resolved
Hide resolved
Yes, it would be useful to add fitting to this routine. I didn't do it yet because it is not very trivial: if |
Right... and also the fitting for the standard protocol (one qubit - one flux protocol) is very unstable at the moment, we should also try to improve the fitting before trying to go for something like this. |
I added the possibility to investigate crosstalk in the fluxlines in the existing
qubit_flux
routine, because it was needed to explain some of the mysteries in the calibration of qw25qB. It can be used by passing the newflux_qubits
parameter, for example:will perform spectroscopy on qubits B1 and B2 (multiplexed) while sweeping the bias of B1, B2, ..., B5 one at a time. Note that this will result to five (in general
len(flux_qubits)
) executions, but I think the biases need to be swept one at a time in order to extract meaningful results.If
flux_qubits
is not given the behavior of the routine will be the same as before. The only difference is the color of the fit (because I changed the order of the plots), but we could force the old color if we need. Also, the colorbar in the crosstalk case is a bit unreadable but I did not try to fix it yet.The same routine can be used to create avoided crossings:
In this plot we are sweeping the bias of qubit B2 (high frequency) while performing spectroscopy and reading B1 (low frequency).
Checklist:
master
main
main