-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize documentation for new layout #511
Conversation
Codecov Report
@@ Coverage Diff @@
## main #511 +/- ##
==========================================
- Coverage 96.28% 96.09% -0.20%
==========================================
Files 63 61 -2
Lines 4636 4503 -133
==========================================
- Hits 4464 4327 -137
- Misses 172 176 +4
Flags with carried forward coverage won't be shown. Click here to find out more. 📢 Thoughts on this report? Let us know!. |
@scarrazza we may also consider removing some outdated documentation related to the RB. |
Ok, fine by me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank @andrea-pasquale. LGTM
I removed it now. |
Looks good, could you please add some image in the front-page summarizing the features in qibocal (one of the xmind we already have)? |
I've just added the image. |
Looks good, thanks |
@andrea-pasquale could you please update poetry and make sure the proper release versions of qibolab/qibo, etc. are correct? |
Qibo it is fine, I believe. |
This could create issues when treating errors later on, given that we will need to merge a PR in qibolab. |
Well, but one of the major points of making a release of qibocal now, is the compatibility with the stable release in qibolab, no? Later we will make another qibolab release and then update this repository. |
Sure I will change it to the stable release |
Tests are not passing because in qibolab we recently merged qiboteam/qibolab#574 |
It is my mistake since I merged #501 which was related to the 0.0.4 release. |
Is it possible to patch qibocal temporarily for the 0.0.3 release, avoiding the usage of this new feature in qibolab? |
I can remove the new protocols from tests and decrease coverage. Otherwise I will need to revert the PR. |
You can do the following, open another PR with the revert changes, we then merge, make a release and finally you revert. |
Revert "Add protocols for TWPA calibration"
Could you please also merge main here? |
Actually I cannot merge it since #512 already started from main. Can I put a merge commit anyway (I'm looking on how to do it). |
Ok, then let's hope that the CI passes. |
@scarrazza after the CI finishes we should be ready to merge . There is only a small decrease in coverage which should be fine I think. |
Sure, lets wait for it. |
This PR uses the same layout for the documentation already used in other qibo repositories.
Now the API reference is also generated automatically.
Checklist:
master
main
main