Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize documentation for new layout #511

Merged
merged 10 commits into from
Sep 8, 2023
Merged

Standardize documentation for new layout #511

merged 10 commits into from
Sep 8, 2023

Conversation

andrea-pasquale
Copy link
Contributor

@andrea-pasquale andrea-pasquale commented Sep 7, 2023

This PR uses the same layout for the documentation already used in other qibo repositories.
Now the API reference is also generated automatically.

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.
  • Compatibility with Qibo modules (Please edit this section if the current pull request is not compatible with the following branches).
    • Qibo: master
    • Qibolab: main
    • Qibolab_platforms_qrc: main

@andrea-pasquale andrea-pasquale added the documentation Improvements or additions to documentation label Sep 7, 2023
@andrea-pasquale andrea-pasquale added this to the Qibocal v0.0.3 milestone Sep 7, 2023
@andrea-pasquale andrea-pasquale self-assigned this Sep 7, 2023
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #511 (aff5c62) into main (00d27e0) will decrease coverage by 0.20%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #511      +/-   ##
==========================================
- Coverage   96.28%   96.09%   -0.20%     
==========================================
  Files          63       61       -2     
  Lines        4636     4503     -133     
==========================================
- Hits         4464     4327     -137     
- Misses        172      176       +4     
Flag Coverage Δ
unittests 96.09% <100.00%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage
src/qibocal/auto/operation.py ø
src/qibocal/protocols/characterization/__init__.py ø
src/qibocal/protocols/characterization/ramsey.py ø
src/qibocal/auto/task.py 100.00%
src/qibocal/fitting/classifier/run.py 100.00%

📢 Thoughts on this report? Let us know!.

@andrea-pasquale
Copy link
Contributor Author

@scarrazza we may also consider removing some outdated documentation related to the RB.
https://github.com/qiboteam/qibocal/tree/new_layout_doc/doc/source/getting-started/niGSC
Mostly because this features are not supported (being able to run protocols without passing through the qibocal API).
I would rather removing it simply because we clean up all the documentation and this is the only old part still present.
Let me know what you think.

@scarrazza
Copy link
Member

Ok, fine by me.

Copy link
Contributor

@Edoardo-Pedicillo Edoardo-Pedicillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank @andrea-pasquale. LGTM

@andrea-pasquale
Copy link
Contributor Author

Ok, fine by me.

I removed it now.

@scarrazza
Copy link
Member

Looks good, could you please add some image in the front-page summarizing the features in qibocal (one of the xmind we already have)?

@andrea-pasquale
Copy link
Contributor Author

I've just added the image.

@scarrazza
Copy link
Member

Looks good, thanks

@scarrazza
Copy link
Member

@andrea-pasquale could you please update poetry and make sure the proper release versions of qibolab/qibo, etc. are correct?

@andrea-pasquale
Copy link
Contributor Author

Qibo it is fine, I believe.
For qibolab, do you want the stable release?

@andrea-pasquale
Copy link
Contributor Author

For qibolab, do you want the stable release?

This could create issues when treating errors later on, given that we will need to merge a PR in qibolab.

@scarrazza
Copy link
Member

Well, but one of the major points of making a release of qibocal now, is the compatibility with the stable release in qibolab, no? Later we will make another qibolab release and then update this repository.

@andrea-pasquale
Copy link
Contributor Author

Well, but one of the major points of making a release of qibocal now, is the compatibility with the stable release in qibolab, no? Later we will make another qibolab release and then update this repository.

Sure I will change it to the stable release

@andrea-pasquale
Copy link
Contributor Author

andrea-pasquale commented Sep 8, 2023

Tests are not passing because in qibolab we recently merged qiboteam/qibolab#574

@andrea-pasquale
Copy link
Contributor Author

It is my mistake since I merged #501 which was related to the 0.0.4 release.

@scarrazza
Copy link
Member

Is it possible to patch qibocal temporarily for the 0.0.3 release, avoiding the usage of this new feature in qibolab?

@andrea-pasquale
Copy link
Contributor Author

andrea-pasquale commented Sep 8, 2023

Is it possible to patch qibocal temporarily for the 0.0.3 release, avoiding the usage of this new feature in qibolab?

I can remove the new protocols from tests and decrease coverage. Otherwise I will need to revert the PR.

@scarrazza
Copy link
Member

You can do the following, open another PR with the revert changes, we then merge, make a release and finally you revert.

@scarrazza
Copy link
Member

Could you please also merge main here?

@andrea-pasquale
Copy link
Contributor Author

Actually I cannot merge it since #512 already started from main. Can I put a merge commit anyway (I'm looking on how to do it).

@scarrazza
Copy link
Member

Ok, then let's hope that the CI passes.

@andrea-pasquale
Copy link
Contributor Author

@scarrazza after the CI finishes we should be ready to merge . There is only a small decrease in coverage which should be fine I think.

@scarrazza
Copy link
Member

Sure, lets wait for it.

@scarrazza scarrazza merged commit 73ec9f0 into main Sep 8, 2023
20 of 21 checks passed
@scarrazza scarrazza deleted the new_layout_doc branch September 8, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants