-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix update not working using qq fit
#536
Conversation
Codecov Report
@@ Coverage Diff @@
## main #536 +/- ##
==========================================
+ Coverage 96.71% 96.72% +0.01%
==========================================
Files 74 74
Lines 5380 5376 -4
==========================================
- Hits 5203 5200 -3
+ Misses 177 176 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
qq fit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fix. I am not very familiar with the auto
part of the code, so it would be great if someone more familiar with it also reviews, but I do not see anything annoying in terms of code.
I also tested the update with one and two routines in the runcard and it worked as expected for the dummy platform. On main it does not work in either case. It may be useful to add a test that checks whether update works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank @andrea-pasquale
While performing some tests I noticed that when using
qq fit
the update is not performed correctly.This PR fixes this issue and it also simplifies the structure of
Task
.Checklist:
master
main
main