Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I've addressed a few issues that were raised in the last meeting.
points
are fixed now thanks to (1).Finally, in the case where we have both a fast sweep and a precision sweep, the fitting before acted separately first on the fast sweep data and then on the precision sweep data. In order to have more statistics I've modified the fitting such that when the precision sweep starts the fitting will not discard the fast sweep data but it will use both datasets to perform the fitting.
In this way we can avoid some weird results when we start generating the precision sweep data.
Let me know if you like this approach @aorgazf @DavidSarlle @maxhant.