Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix variable name in classifier fitting #553

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Conversation

MatteoRobbiati
Copy link
Contributor

Small fix to che classifier routine.

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.
  • Compatibility with Qibo modules (Please edit this section if the current pull request is not compatible with the following branches).
    • Qibo: master
    • Qibolab: main
    • Qibolab_platforms_qrc: main

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #553 (b381353) into main (cea9d85) will increase coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #553      +/-   ##
==========================================
+ Coverage   95.90%   95.95%   +0.05%     
==========================================
  Files          83       83              
  Lines        5740     5740              
==========================================
+ Hits         5505     5508       +3     
+ Misses        235      232       -3     
Flag Coverage Δ
unittests 95.95% <0.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/qibocal/fitting/classifier/run.py 96.69% <0.00%> (ø)

... and 1 file with indirect coverage changes

@andrea-pasquale
Copy link
Contributor

@MatteoRobbiati if you merge main here I believe that tests should pass

@andrea-pasquale
Copy link
Contributor

@Edoardo-Pedicillo could you please check if coverage could be fixed?

Copy link
Contributor

@Edoardo-Pedicillo Edoardo-Pedicillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank @MatteoRobbiati lgtm

@andrea-pasquale andrea-pasquale added this pull request to the merge queue Oct 13, 2023
Merged via the queue into main with commit 7d4fef0 Oct 13, 2023
20 of 21 checks passed
@andrea-pasquale andrea-pasquale deleted the fix-classifier branch October 13, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants