Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring action parameters #559

Merged
merged 7 commits into from
Oct 17, 2023
Merged

Conversation

GabrielePalazzo
Copy link
Contributor

Closes #551.

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.
  • Compatibility with Qibo modules (Please edit this section if the current pull request is not compatible with the following branches).
    • Qibo: master
    • Qibolab: main
    • Qibolab_platforms_qrc: main

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #559 (00b3c70) into main (cea9d85) will decrease coverage by 0.10%.
Report is 3 commits behind head on main.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #559      +/-   ##
==========================================
- Coverage   95.90%   95.81%   -0.10%     
==========================================
  Files          83       83              
  Lines        5740     5612     -128     
==========================================
- Hits         5505     5377     -128     
  Misses        235      235              
Flag Coverage Δ
unittests 95.81% <100.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/qibocal/auto/operation.py 100.00% <100.00%> (ø)
.../qibocal/protocols/characterization/allxy/allxy.py 100.00% <ø> (ø)
.../characterization/allxy/allxy_drag_pulse_tuning.py 100.00% <ø> (ø)
...tocols/characterization/allxy/drag_pulse_tuning.py 100.00% <ø> (ø)
...bocal/protocols/characterization/classification.py 100.00% <ø> (ø)
.../protocols/characterization/coherence/spin_echo.py 100.00% <ø> (ø)
...qibocal/protocols/characterization/coherence/t1.py 100.00% <ø> (ø)
...qibocal/protocols/characterization/coherence/t2.py 100.00% <ø> (ø)
...bocal/protocols/characterization/coherence/zeno.py 100.00% <ø> (ø)
...cal/protocols/characterization/dispersive_shift.py 100.00% <ø> (ø)
... and 22 more

Copy link
Contributor

@andrea-pasquale andrea-pasquale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@Edoardo-Pedicillo Edoardo-Pedicillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GabrielePalazzo GabrielePalazzo added this pull request to the merge queue Oct 17, 2023
Merged via the queue into main with commit fdc62be Oct 17, 2023
21 checks passed
@GabrielePalazzo GabrielePalazzo deleted the refactoring_action_parameters branch October 17, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove nshots and relaxation_time
3 participants