Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hpars #588

Merged
merged 4 commits into from
Oct 27, 2023
Merged

Fix hpars #588

merged 4 commits into from
Oct 27, 2023

Conversation

Edoardo-Pedicillo
Copy link
Contributor

Solves #586

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.
  • Compatibility with Qibo modules (Please edit this section if the current pull request is not compatible with the following branches).
    • Qibo: master
    • Qibolab: main
    • Qibolab_platforms_qrc: main

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #588 (aaf4360) into main (7893a8c) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #588      +/-   ##
==========================================
+ Coverage   96.05%   96.10%   +0.04%     
==========================================
  Files          92       92              
  Lines        6164     6156       -8     
==========================================
- Hits         5921     5916       -5     
+ Misses        243      240       -3     
Flag Coverage Δ
unittests 96.10% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/qibocal/fitting/classifier/run.py 97.47% <100.00%> (+0.78%) ⬆️
...bocal/protocols/characterization/classification.py 100.00% <100.00%> (+0.53%) ⬆️
...rotocols/characterization/qutrit_classification.py 97.53% <ø> (-0.06%) ⬇️
src/qibocal/protocols/characterization/utils.py 97.23% <100.00%> (ø)

... and 2 files with indirect coverage changes

@Edoardo-Pedicillo Edoardo-Pedicillo added this pull request to the merge queue Oct 27, 2023
Merged via the queue into main with commit 7098692 Oct 27, 2023
21 checks passed
@Edoardo-Pedicillo Edoardo-Pedicillo deleted the fix_hpars branch October 27, 2023 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'Qubit' object has no attribute 'classifiers_hpars' Error
3 participants