Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix chevron for no couplers #591

Merged
merged 1 commit into from
Oct 27, 2023
Merged

fix chevron for no couplers #591

merged 1 commit into from
Oct 27, 2023

Conversation

Jacfomg
Copy link
Contributor

@Jacfomg Jacfomg commented Oct 26, 2023

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.
  • Compatibility with Qibo modules (Please edit this section if the current pull request is not compatible with the following branches).
    • Qibo: master
    • Qibolab: couplers2
    • Qibolab_platforms_qrc: main

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #591 (90e8670) into main (7893a8c) will decrease coverage by 0.05%.
Report is 5 commits behind head on main.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #591      +/-   ##
==========================================
- Coverage   96.05%   96.00%   -0.05%     
==========================================
  Files          92       92              
  Lines        6164     6165       +1     
==========================================
- Hits         5921     5919       -2     
- Misses        243      246       +3     
Flag Coverage Δ
unittests 96.00% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../characterization/two_qubit_interaction/chevron.py 97.70% <100.00%> (+0.01%) ⬆️

... and 1 file with indirect coverage changes

Copy link
Contributor

@andrea-pasquale andrea-pasquale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Jacfomg, LGTM and it works on qw5q_gold.

@andrea-pasquale andrea-pasquale linked an issue Oct 27, 2023 that may be closed by this pull request
@andrea-pasquale andrea-pasquale added this pull request to the merge queue Oct 27, 2023
Merged via the queue into main with commit a731ce0 Oct 27, 2023
21 checks passed
@andrea-pasquale andrea-pasquale deleted the fix-couplers branch October 27, 2023 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Couplers Breaking Changes
3 participants