Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added url strings for homepage and documentation #604

Merged
merged 7 commits into from
Nov 6, 2023

Conversation

GabrielePalazzo
Copy link
Contributor

Closes #603.

Let me know if it is a reasonable solution or if you want to discard it.

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.
  • Compatibility with Qibo modules (Please edit this section if the current pull request is not compatible with the following branches).
    • Qibo: master
    • Qibolab: main
    • Qibolab_platforms_qrc: main

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #604 (e6b67b4) into main (15bb374) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #604   +/-   ##
=======================================
  Coverage   96.34%   96.34%           
=======================================
  Files          99       99           
  Lines        6733     6733           
=======================================
  Hits         6487     6487           
  Misses        246      246           
Flag Coverage Δ
unittests 96.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
GabrielePalazzo and others added 2 commits November 3, 2023 17:24
Co-authored-by: Stefano Carrazza <[email protected]>
Co-authored-by: Stefano Carrazza <[email protected]>
@scarrazza
Copy link
Member

Thanks, could you please also replace the description with " Qibo's quantum calibration, characterization and validation module."?

@GabrielePalazzo
Copy link
Contributor Author

@scarrazza @andrea-pasquale please have a final look, since something weird happened with git (it reverted some previous commits). Now it should all be ok.

@andrea-pasquale
Copy link
Contributor

The final version looks good to me. I've just relaunched the CI. Feel free to merge as soon as tests are passing.

@GabrielePalazzo GabrielePalazzo added this pull request to the merge queue Nov 6, 2023
Merged via the queue into main with commit d0a9701 Nov 6, 2023
21 checks passed
@GabrielePalazzo GabrielePalazzo deleted the pip_install_error branch November 6, 2023 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot install with pip (data.homepage must be uri)
3 participants