-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sequence unrolling in standard RB #610
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #610 +/- ##
==========================================
- Coverage 97.32% 97.28% -0.04%
==========================================
Files 106 106
Lines 7057 7065 +8
==========================================
+ Hits 6868 6873 +5
- Misses 189 192 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@stavros11 do you think that we can have this for the 0.0.7? Ideally I believe that release should happen at the beginning of january |
I fixed the conflicts, this should be ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @stavros11, LGTM.
I will try it on hardware as soon as we have a calibrated chip.
You kept the deploy on hardware
label because you still need to run it on hardware or because you have not been able to run it on a calibrated chip?
Thanks for the review.
Yes, I tried it with qw5q_gold and it works but the results look a bit different with and without unrolling:
so I would prefer to also try with a calibrated qubit which has a reasonable (not just noise) RB using the main branch, to make sure it is consistent here. |
Requires qiboteam/qibolab#618. I temporarily modified the pyproject.toml to include this dependency.
I added the unrolling as an option as it may be useful to benchmark with and without.
I only tested locally with the dummy. I am planning to test and also benchmark with instruments when they are available. So far this is expected to work well only with qblox.
Checklist:
master
unrolling
main