Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sequence unrolling in standard RB #610

Merged
merged 4 commits into from
Feb 2, 2024
Merged

Sequence unrolling in standard RB #610

merged 4 commits into from
Feb 2, 2024

Conversation

stavros11
Copy link
Member

@stavros11 stavros11 commented Nov 7, 2023

Requires qiboteam/qibolab#618. I temporarily modified the pyproject.toml to include this dependency.

I added the unrolling as an option as it may be useful to benchmark with and without.
I only tested locally with the dummy. I am planning to test and also benchmark with instruments when they are available. So far this is expected to work well only with qblox.

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.
  • Compatibility with Qibo modules (Please edit this section if the current pull request is not compatible with the following branches).
    • Qibo: master
    • Qibolab: unrolling
    • Qibolab_platforms_qrc: main

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e9d484c) 97.32% compared to head (f42a9f6) 97.28%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #610      +/-   ##
==========================================
- Coverage   97.32%   97.28%   -0.04%     
==========================================
  Files         106      106              
  Lines        7057     7065       +8     
==========================================
+ Hits         6868     6873       +5     
- Misses        189      192       +3     
Flag Coverage Δ
unittests 97.28% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...cterization/randomized_benchmarking/standard_rb.py 98.72% <100.00%> (+0.06%) ⬆️

... and 1 file with indirect coverage changes

@andrea-pasquale andrea-pasquale added rb Randomized benchmarking qibolab release required PR requires qibolab feature not available in the current poetry.lock labels Nov 8, 2023
@andrea-pasquale
Copy link
Contributor

@stavros11 do you think that we can have this for the 0.0.7? Ideally I believe that release should happen at the beginning of january

@stavros11
Copy link
Member Author

I fixed the conflicts, this should be ready.

@andrea-pasquale andrea-pasquale removed the qibolab release required PR requires qibolab feature not available in the current poetry.lock label Dec 27, 2023
Copy link
Contributor

@andrea-pasquale andrea-pasquale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stavros11, LGTM.
I will try it on hardware as soon as we have a calibrated chip.
You kept the deploy on hardware label because you still need to run it on hardware or because you have not been able to run it on a calibrated chip?

@stavros11
Copy link
Member Author

stavros11 commented Dec 28, 2023

Thanks for the review.

You kept the deploy on hardware label because you still need to run on it on hardware or because you have not been able to run in on a calibrated chip?

Yes, I tried it with qw5q_gold and it works but the results look a bit different with and without unrolling:

so I would prefer to also try with a calibrated qubit which has a reasonable (not just noise) RB using the main branch, to make sure it is consistent here.

@andrea-pasquale andrea-pasquale added this pull request to the merge queue Feb 2, 2024
Merged via the queue into main with commit 2f7d459 Feb 2, 2024
21 checks passed
@andrea-pasquale andrea-pasquale deleted the rbunrolling branch February 2, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rb Randomized benchmarking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants