Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mitigation matrix #622

Merged
merged 2 commits into from
Nov 14, 2023
Merged

fix mitigation matrix #622

merged 2 commits into from
Nov 14, 2023

Conversation

Edoardo-Pedicillo
Copy link
Contributor

It closes #615.
I decided to delete create_annotated_heatmap since it is deprecated.
The suggested replacement is imshow from plotly express, but because of a problem with dash, it is not able to diplay the text on the matrix cells.
Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.
  • Compatibility with Qibo modules (Please edit this section if the current pull request is not compatible with the following branches).
    • Qibo: master
    • Qibolab: main
    • Qibolab_platforms_qrc: main

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #622 (624d4c0) into main (478360a) will decrease coverage by 0.01%.
Report is 63 commits behind head on main.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #622      +/-   ##
==========================================
- Coverage   95.90%   95.89%   -0.01%     
==========================================
  Files         102      102              
  Lines        7103     7097       -6     
==========================================
- Hits         6812     6806       -6     
  Misses        291      291              
Flag Coverage Δ
unittests 95.89% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...cols/characterization/readout_mitigation_matrix.py 95.91% <100.00%> (-0.24%) ⬇️

@andrea-pasquale andrea-pasquale added this pull request to the merge queue Nov 14, 2023
Merged via the queue into main with commit ecad841 Nov 14, 2023
23 checks passed
@andrea-pasquale andrea-pasquale deleted the matrix_report branch November 14, 2023 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve plotting on readout_mitigation_matrix protocols
3 participants