Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plot clouds in readout_characterization #628

Merged
merged 5 commits into from
Nov 15, 2023
Merged

plot clouds in readout_characterization #628

merged 5 commits into from
Nov 15, 2023

Conversation

Edoardo-Pedicillo
Copy link
Contributor

It closes #616

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.
  • Compatibility with Qibo modules (Please edit this section if the current pull request is not compatible with the following branches).
    • Qibo: master
    • Qibolab: main
    • Qibolab_platforms_qrc: main

@Jacfomg
Copy link
Contributor

Jacfomg commented Nov 14, 2023

Have we tested that the QubitFit is doing the same as Zurich ? Because the point of this routine was to test the discrimination the machines were doing. Apart from that and maybe having the plots side to side instead of one in of the other, it looks good. I would love to test on a calibrated qubit.

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Merging #628 (613fc1a) into main (9c3ee68) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #628   +/-   ##
=======================================
  Coverage   95.96%   95.96%           
=======================================
  Files         103      103           
  Lines        7232     7236    +4     
=======================================
+ Hits         6940     6944    +4     
  Misses        292      292           
Flag Coverage Δ
unittests 95.96% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ocols/characterization/readout_characterization.py 100.00% <100.00%> (ø)

Copy link
Contributor

@andrea-pasquale andrea-pasquale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks looks good to me.
Just a small comment.

go.Scatter(
x=shots.i,
y=shots.q,
name=f"state {state} measure {measure}",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we could use a better label here.

Copy link
Contributor

@Jacfomg Jacfomg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you feel like it, I think having two plots one next to the other like the signal and phase ones would look nicer.

@Edoardo-Pedicillo Edoardo-Pedicillo added this pull request to the merge queue Nov 15, 2023
Merged via the queue into main with commit fb8d96f Nov 15, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show iq clouds in readout_characterization and refactor matrix
4 participants