-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plot clouds in readout_characterization #628
Conversation
Have we tested that the QubitFit is doing the same as Zurich ? Because the point of this routine was to test the discrimination the machines were doing. Apart from that and maybe having the plots side to side instead of one in of the other, it looks good. I would love to test on a calibrated qubit. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #628 +/- ##
=======================================
Coverage 95.96% 95.96%
=======================================
Files 103 103
Lines 7232 7236 +4
=======================================
+ Hits 6940 6944 +4
Misses 292 292
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks looks good to me.
Just a small comment.
go.Scatter( | ||
x=shots.i, | ||
y=shots.q, | ||
name=f"state {state} measure {measure}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we could use a better label here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you feel like it, I think having two plots one next to the other like the signal and phase ones would look nicer.
It closes #616
Checklist:
master
main
main