-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tune landscape protocol #634
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #634 +/- ##
==========================================
+ Coverage 97.25% 97.31% +0.06%
==========================================
Files 101 103 +2
Lines 7471 7610 +139
==========================================
+ Hits 7266 7406 +140
+ Misses 205 204 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
On hardware everything seems fine: http://login.qrccluster.com:9000/TrK3STtmSfm7laYzWFcRHQ==/ |
src/qibocal/protocols/characterization/two_qubit_interaction/tune_landscape.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Edoardo Pedicillo <[email protected]>
for more information, see https://pre-commit.ci
I have the impression the without thinking or having some sweepers for the tuned lanscape protocol it would take over an hour to reproduce the plots presented in the paper. I would leave it in another PR for the time being and I will review the rest of this PR. |
src/qibocal/protocols/characterization/two_qubit_interaction/cz_virtualz.py
Show resolved
Hide resolved
src/qibocal/protocols/characterization/two_qubit_interaction/cz_virtualz.py
Outdated
Show resolved
Hide resolved
src/qibocal/protocols/characterization/two_qubit_interaction/cz_virtualz.py
Outdated
Show resolved
Hide resolved
src/qibocal/protocols/characterization/two_qubit_interaction/cz_virtualz_signal.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the tune_landscape all the rest seems fine to me.
This PR implements a tune landscape protocol, i.e. repeating the
cz_virtualz
protocol for different values of amplitude and duration of the flux pulse that implements the CZ gate. I've taken inspiration from the NZ paper https://arxiv.org/pdf/1903.02492.pdf.Eventually we could add different protocols when we want to use more specialized pulse sweeping over specific parameteres, like they are doing in the paper (or with the SNZ), assuming that this is feature is provided by qibolab.
Now the implementation is quite naive since I am using for loops. I would like to use sweepers, but I don't know whether it is possible to sweep 3 parameters at the same time (phase, amplitude and duration in this case)....
I guess have something working with for loops is better than nothing.
After deploying on hardware I want to add also a fitting function.
Checklist:
master
main
main