Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tune landscape protocol #634

Merged
merged 19 commits into from
Apr 4, 2024
Merged

Add tune landscape protocol #634

merged 19 commits into from
Apr 4, 2024

Conversation

andrea-pasquale
Copy link
Contributor

@andrea-pasquale andrea-pasquale commented Nov 20, 2023

This PR implements a tune landscape protocol, i.e. repeating the cz_virtualz protocol for different values of amplitude and duration of the flux pulse that implements the CZ gate. I've taken inspiration from the NZ paper https://arxiv.org/pdf/1903.02492.pdf.
Eventually we could add different protocols when we want to use more specialized pulse sweeping over specific parameteres, like they are doing in the paper (or with the SNZ), assuming that this is feature is provided by qibolab.

Now the implementation is quite naive since I am using for loops. I would like to use sweepers, but I don't know whether it is possible to sweep 3 parameters at the same time (phase, amplitude and duration in this case)....
I guess have something working with for loops is better than nothing.

After deploying on hardware I want to add also a fitting function.

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.
  • Compatibility with Qibo modules (Please edit this section if the current pull request is not compatible with the following branches).
    • Qibo: master
    • Qibolab: main
    • Qibolab_platforms_qrc: main

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Attention: Patch coverage is 98.74214% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 97.31%. Comparing base (e7a18a9) to head (6b7229f).

❗ Current head 6b7229f differs from pull request most recent head 0e69f41. Consider uploading reports for the commit 0e69f41 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #634      +/-   ##
==========================================
+ Coverage   97.25%   97.31%   +0.06%     
==========================================
  Files         101      103       +2     
  Lines        7471     7610     +139     
==========================================
+ Hits         7266     7406     +140     
+ Misses        205      204       -1     
Flag Coverage Δ
unittests 97.31% <98.74%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/qibocal/protocols/characterization/__init__.py 100.00% <100.00%> (ø)
...ocols/characterization/couplers/coupler_chevron.py 100.00% <100.00%> (ø)
...cterization/couplers/coupler_qubit_spectroscopy.py 100.00% <100.00%> (ø)
...ization/couplers/coupler_resonator_spectroscopy.py 100.00% <100.00%> (ø)
...aracterization/flux_dependence/avoided_crossing.py 87.58% <100.00%> (ø)
...characterization/two_qubit_interaction/__init__.py 100.00% <100.00%> (ø)
.../characterization/two_qubit_interaction/chevron.py 96.47% <100.00%> (+0.21%) ⬆️
...zation/two_qubit_interaction/cz_virtualz_signal.py 100.00% <100.00%> (ø)
...terization/two_qubit_interaction/tune_landscape.py 100.00% <100.00%> (ø)
...ls/characterization/two_qubit_interaction/utils.py 100.00% <100.00%> (ø)
... and 1 more

... and 1 file with indirect coverage changes

@andrea-pasquale andrea-pasquale changed the base branch from main to fix_cz_table March 22, 2024 13:14
@andrea-pasquale andrea-pasquale added this to the Qibocal 0.0.8 milestone Mar 22, 2024
@andrea-pasquale andrea-pasquale marked this pull request as ready for review March 22, 2024 13:50
@andrea-pasquale
Copy link
Contributor Author

On hardware everything seems fine: http://login.qrccluster.com:9000/TrK3STtmSfm7laYzWFcRHQ==/

Base automatically changed from fix_cz_table to main April 1, 2024 04:36
@Jacfomg
Copy link
Contributor

Jacfomg commented Apr 3, 2024

I have the impression the without thinking or having some sweepers for the tuned lanscape protocol it would take over an hour to reproduce the plots presented in the paper. I would leave it in another PR for the time being and I will review the rest of this PR.

Copy link
Contributor

@Jacfomg Jacfomg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the tune_landscape all the rest seems fine to me.

@andrea-pasquale andrea-pasquale added this pull request to the merge queue Apr 4, 2024
Merged via the queue into main with commit 8dd2e15 Apr 4, 2024
11 of 19 checks passed
@andrea-pasquale andrea-pasquale deleted the tune_landscape branch April 4, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants