-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix fit Rabi #651
Fix fit Rabi #651
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #651 +/- ##
==========================================
+ Coverage 96.03% 96.06% +0.02%
==========================================
Files 106 106
Lines 7347 7339 -8
==========================================
- Hits 7056 7050 -6
+ Misses 291 289 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Edoardo-Pedicillo, LGTM.
return "amp", "Amplitude (dimensionless)", rabi_amplitude_function | ||
elif "RabiLength" in data.__class__.__name__: | ||
return "length", "Time (ns)", rabi_length_function | ||
raise RuntimeError("Data has to be a data structure of the Rabi routines.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you can could add a quick test for this function to increase coverage.
Co-authored-by: Gabriele Palazzo <[email protected]>
Co-authored-by: Gabriele Palazzo <[email protected]>
Co-authored-by: Alessandro Candido <[email protected]>
This PR fix Rabi fit and refactor Rabi utils.
Checklist:
master
main
main