Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fit Rabi #651

Merged
merged 17 commits into from
Dec 6, 2023
Merged

Fix fit Rabi #651

merged 17 commits into from
Dec 6, 2023

Conversation

Edoardo-Pedicillo
Copy link
Contributor

@Edoardo-Pedicillo Edoardo-Pedicillo commented Dec 4, 2023

This PR fix Rabi fit and refactor Rabi utils.
Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.
  • Compatibility with Qibo modules (Please edit this section if the current pull request is not compatible with the following branches).
    • Qibo: master
    • Qibolab: main
    • Qibolab_platforms_qrc: main

@Edoardo-Pedicillo Edoardo-Pedicillo changed the title Fix fit ramsey Fix fit Rabi Dec 4, 2023
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Merging #651 (4e2863f) into main (8398e2b) will increase coverage by 0.02%.
Report is 27 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #651      +/-   ##
==========================================
+ Coverage   96.03%   96.06%   +0.02%     
==========================================
  Files         106      106              
  Lines        7347     7339       -8     
==========================================
- Hits         7056     7050       -6     
+ Misses        291      289       -2     
Flag Coverage Δ
unittests 96.06% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/qibocal/auto/task.py 100.00% <ø> (ø)
...bocal/protocols/characterization/rabi/amplitude.py 94.94% <ø> (ø)
...rotocols/characterization/rabi/amplitude_signal.py 93.75% <ø> (ø)
.../qibocal/protocols/characterization/rabi/length.py 95.91% <100.00%> (ø)
...l/protocols/characterization/rabi/length_signal.py 97.50% <100.00%> (+2.50%) ⬆️
...c/qibocal/protocols/characterization/rabi/utils.py 100.00% <100.00%> (ø)

@Edoardo-Pedicillo Edoardo-Pedicillo marked this pull request as ready for review December 5, 2023 07:24
Copy link
Contributor

@andrea-pasquale andrea-pasquale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Edoardo-Pedicillo, LGTM.

Base automatically changed from fix_op_mode to main December 5, 2023 08:43
return "amp", "Amplitude (dimensionless)", rabi_amplitude_function
elif "RabiLength" in data.__class__.__name__:
return "length", "Time (ns)", rabi_length_function
raise RuntimeError("Data has to be a data structure of the Rabi routines.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can could add a quick test for this function to increase coverage.

@andrea-pasquale andrea-pasquale added this pull request to the merge queue Dec 6, 2023
Merged via the queue into main with commit b319f13 Dec 6, 2023
21 checks passed
@andrea-pasquale andrea-pasquale deleted the fix_fit_ramsey branch December 6, 2023 09:54
@andrea-pasquale andrea-pasquale mentioned this pull request Dec 18, 2023
2 tasks
@andrea-pasquale andrea-pasquale mentioned this pull request Jul 3, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants