Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert frequency from GHz to Hz in qubit flux dependence #657

Merged
merged 3 commits into from
Dec 7, 2023

Conversation

andrea-pasquale
Copy link
Contributor

@andrea-pasquale andrea-pasquale commented Dec 6, 2023

This PR fixes a factor 10^9 which was wrong in qubit flux dependence.
@Edoardo-Pedicillo @GabrielePalazzo let's try to merge this before the release
Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.
  • Compatibility with Qibo modules (Please edit this section if the current pull request is not compatible with the following branches).
    • Qibo: master
    • Qibolab: main
    • Qibolab_platforms_qrc: main

@andrea-pasquale andrea-pasquale added the bug Something isn't working label Dec 6, 2023
@andrea-pasquale andrea-pasquale added this to the Qibocal 0.0.6 milestone Dec 6, 2023
@andrea-pasquale andrea-pasquale self-assigned this Dec 6, 2023
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Merging #657 (d1112d7) into main (ae9d1e6) will decrease coverage by 0.07%.
Report is 20 commits behind head on main.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #657      +/-   ##
==========================================
- Coverage   96.09%   96.02%   -0.07%     
==========================================
  Files         106      106              
  Lines        7350     7350              
==========================================
- Hits         7063     7058       -5     
- Misses        287      292       +5     
Flag Coverage Δ
unittests 96.02% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../characterization/allxy/allxy_drag_pulse_tuning.py 100.00% <ø> (ø)
...tocols/characterization/allxy/drag_pulse_tuning.py 100.00% <ø> (ø)
...erization/flux_dependence/qubit_flux_dependence.py 88.81% <0.00%> (ø)

... and 2 files with indirect coverage changes

Tests were failing after running them with qibolab 0.1.4.
I've fixed them after applying the same fix already present in allXY protocol.
@andrea-pasquale
Copy link
Contributor Author

@scarrazza now that tests are passing I will merge and you are free to make a release also for qibocal.

@andrea-pasquale andrea-pasquale added this pull request to the merge queue Dec 7, 2023
Merged via the queue into main with commit e08368e Dec 7, 2023
20 of 21 checks passed
@andrea-pasquale andrea-pasquale deleted the fix_conversion branch December 7, 2023 08:43
@scarrazza
Copy link
Member

Thanks @andrea-pasquale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants