Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing end-time and hrefs in report #658

Merged
merged 2 commits into from
Dec 12, 2023
Merged

Fixing end-time and hrefs in report #658

merged 2 commits into from
Dec 12, 2023

Conversation

andrea-pasquale
Copy link
Contributor

Closes #655.

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.
  • Compatibility with Qibo modules (Please edit this section if the current pull request is not compatible with the following branches).
    • Qibo: master
    • Qibolab: main
    • Qibolab_platforms_qrc: main

Closes #655. There was an error in template.html regarding the hrefs.
For the end-time the meta needed to be dumped after each action.
Removing autocalibration.html since the current report is rendered using template.html
@andrea-pasquale andrea-pasquale added the bug Something isn't working label Dec 7, 2023
@andrea-pasquale andrea-pasquale added this to the Qibocal 0.0.7 milestone Dec 7, 2023
@andrea-pasquale andrea-pasquale self-assigned this Dec 7, 2023
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Merging #658 (2b74dcc) into main (e08368e) will decrease coverage by 0.06%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #658      +/-   ##
==========================================
- Coverage   96.10%   96.05%   -0.06%     
==========================================
  Files         106      106              
  Lines        7342     7342              
==========================================
- Hits         7056     7052       -4     
- Misses        286      290       +4     
Flag Coverage Δ
unittests 96.05% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/qibocal/cli/autocalibration.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@andrea-pasquale andrea-pasquale added this pull request to the merge queue Dec 12, 2023
Merged via the queue into main with commit 5f10133 Dec 12, 2023
21 checks passed
@andrea-pasquale andrea-pasquale deleted the fix_report branch December 12, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Report Issues
3 participants