Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create AbstractData #670

Merged
merged 5 commits into from
Dec 13, 2023
Merged

create AbstractData #670

merged 5 commits into from
Dec 13, 2023

Conversation

Edoardo-Pedicillo
Copy link
Contributor

@Edoardo-Pedicillo Edoardo-Pedicillo commented Dec 12, 2023

Create AbstractData class from which Data and Results inherit
https://github.com/qiboteam/qibocal/pull/582/files#r1377559448
Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.
  • Compatibility with Qibo modules (Please edit this section if the current pull request is not compatible with the following branches).
    • Qibo: master
    • Qibolab: main
    • Qibolab_platforms_qrc: main

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Merging #670 (fc89963) into kernels (35a6873) will increase coverage by 0.00%.
Report is 79 commits behind head on kernels.
The diff coverage is 96.22%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           kernels     #670   +/-   ##
========================================
  Coverage    96.05%   96.05%           
========================================
  Files          107      107           
  Lines         7431     7432    +1     
========================================
+ Hits          7138     7139    +1     
  Misses         293      293           
Flag Coverage Δ
unittests 96.05% <96.22%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/qibocal/auto/operation.py 98.91% <96.22%> (+1.64%) ⬆️

... and 1 file with indirect coverage changes

@Edoardo-Pedicillo Edoardo-Pedicillo marked this pull request as ready for review December 12, 2023 11:05
src/qibocal/auto/operation.py Outdated Show resolved Hide resolved
src/qibocal/auto/operation.py Outdated Show resolved Hide resolved
src/qibocal/auto/operation.py Outdated Show resolved Hide resolved
src/qibocal/auto/operation.py Outdated Show resolved Hide resolved
src/qibocal/auto/operation.py Outdated Show resolved Hide resolved
src/qibocal/auto/operation.py Outdated Show resolved Hide resolved
src/qibocal/auto/operation.py Outdated Show resolved Hide resolved
src/qibocal/auto/operation.py Outdated Show resolved Hide resolved
src/qibocal/auto/operation.py Outdated Show resolved Hide resolved
src/qibocal/auto/operation.py Outdated Show resolved Hide resolved
Co-authored-by: Andrea Pasquale <[email protected]>
@Edoardo-Pedicillo Edoardo-Pedicillo merged commit 5c13668 into kernels Dec 13, 2023
21 checks passed
@Edoardo-Pedicillo Edoardo-Pedicillo deleted the refactor_data branch December 13, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants