-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding ramsey sequences signal protocol #674
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #674 +/- ##
==========================================
- Coverage 96.05% 96.03% -0.03%
==========================================
Files 106 108 +2
Lines 7355 7386 +31
==========================================
+ Hits 7065 7093 +28
- Misses 290 293 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything seems ok to me (tested on qblox).
Out of curiosity, is this only needed for doing non-detuned Ramsey with sequences without sweepers? Because last week Boulos also contacted me about a similar issue and I remember that using the existing Ramsey would fall back to sequences if I set |
When he spoke to me I think that the major issue was the fact that we wanted to run long scans, therefore he needed to use the |
Yes, I think the existing ramsey_signal uses sweeper when
So in the end it should be equivalent to the new routine added here for |
Oh yes, you are right. I will double check with @Boulos-Alfakes and I can close the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank @andrea-pasquale, LGTM
I think that probably we will not need this PR. Let me close it for now and if it will be necessary I will open the PR again. |
Closes #673.
This protocol could be useful to run long scans without using sweepers. It might be replaced by the unrolled version #666 soon.
@GabrielePalazzo @PiergiorgioButtarini whenever you have time could test it on qblox to see if the output is the same?
Here is an example of a runcard:
Checklist:
master
main
main