-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove platform.start()
#688
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_of_flight_readout.py Co-authored-by: Stavros Efthymiou <[email protected]>
stavros11
added
the
qibolab release required
PR requires qibolab feature not available in the current poetry.lock
label
Jan 12, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #688 +/- ##
==========================================
- Coverage 96.01% 95.98% -0.04%
==========================================
Files 106 106
Lines 7356 7349 -7
==========================================
- Hits 7063 7054 -9
- Misses 293 295 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
andrea-pasquale
approved these changes
Jan 12, 2024
Jacfomg
approved these changes
Jan 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tried it for Zurich, it works
4 tasks
8 tasks
Updating mechanism to dump platforms
andrea-pasquale
removed
the
qibolab release required
PR requires qibolab feature not available in the current poetry.lock
label
Jan 27, 2024
Fix TOF routine with new sampling rate approach
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of qiboteam/qibolab#739,
platform.start()
,setup()
andstop()
will not be available.Checklist:
master
main
main