Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove platform.start() #688

Merged
merged 17 commits into from
Jan 27, 2024
Merged

Remove platform.start() #688

merged 17 commits into from
Jan 27, 2024

Conversation

stavros11
Copy link
Member

As of qiboteam/qibolab#739, platform.start(), setup() and stop() will not be available.

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.
  • Compatibility with Qibo modules (Please edit this section if the current pull request is not compatible with the following branches).
    • Qibo: master
    • Qibolab: main
    • Qibolab_platforms_qrc: main

@stavros11 stavros11 added the qibolab release required PR requires qibolab feature not available in the current poetry.lock label Jan 12, 2024
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5061441) 96.01% compared to head (892fe70) 95.98%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #688      +/-   ##
==========================================
- Coverage   96.01%   95.98%   -0.04%     
==========================================
  Files         106      106              
  Lines        7356     7349       -7     
==========================================
- Hits         7063     7054       -9     
- Misses        293      295       +2     
Flag Coverage Δ
unittests 95.98% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/qibocal/cli/acquisition.py 100.00% <100.00%> (ø)
src/qibocal/cli/autocalibration.py 100.00% <100.00%> (ø)
src/qibocal/cli/utils.py 74.13% <100.00%> (ø)
...acterization/resonator_spectroscopy_attenuation.py 98.85% <100.00%> (ø)
...ation/signal_experiments/time_of_flight_readout.py 100.00% <ø> (ø)
.../characterization/two_qubit_interaction/chevron.py 95.41% <ø> (-1.53%) ⬇️
src/qibocal/update.py 96.11% <ø> (-0.15%) ⬇️
src/qibocal/utils.py 100.00% <100.00%> (ø)

@andrea-pasquale andrea-pasquale added this to the Qibocal 0.0.7 milestone Jan 12, 2024
Copy link
Contributor

@Jacfomg Jacfomg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tried it for Zurich, it works

Updating mechanism to dump platforms
@andrea-pasquale andrea-pasquale removed the qibolab release required PR requires qibolab feature not available in the current poetry.lock label Jan 27, 2024
Fix TOF routine with new sampling rate approach
@andrea-pasquale andrea-pasquale added this pull request to the merge queue Jan 27, 2024
Merged via the queue into main with commit 82a2125 Jan 27, 2024
21 checks passed
@andrea-pasquale andrea-pasquale deleted the rmstart branch January 27, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants