Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix temperature #697

Merged
merged 1 commit into from
Feb 1, 2024
Merged

fix temperature #697

merged 1 commit into from
Feb 1, 2024

Conversation

Edoardo-Pedicillo
Copy link
Contributor

This PR fixes #676, the issue was that the temperature was evaluated on the dataset with ground and excited points. What it should be done (not sure) is to consider the dataset containing only the ground state and evaluate the temperature with its predictions.

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.
  • Compatibility with Qibo modules (Please edit this section if the current pull request is not compatible with the following branches).
    • Qibo: master
    • Qibolab: main
    • Qibolab_platforms_qrc: main

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5061441) 96.01% compared to head (01107ef) 95.97%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #697      +/-   ##
==========================================
- Coverage   96.01%   95.97%   -0.04%     
==========================================
  Files         106      106              
  Lines        7356     7359       +3     
==========================================
  Hits         7063     7063              
- Misses        293      296       +3     
Flag Coverage Δ
unittests 95.97% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...bocal/protocols/characterization/classification.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Contributor

@Jacfomg Jacfomg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrea-pasquale andrea-pasquale added this pull request to the merge queue Feb 1, 2024
Merged via the queue into main with commit 8b6722a Feb 1, 2024
21 checks passed
@andrea-pasquale andrea-pasquale deleted the temperature branch February 1, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix T_eff in single shot classification
3 participants