Dump platform iteratively #710
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #710 +/- ##
==========================================
+ Coverage 97.25% 97.28% +0.02%
==========================================
Files 109 109
Lines 7502 7507 +5
==========================================
+ Hits 7296 7303 +7
+ Misses 206 204 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
src/qibocal/auto/task.py
Outdated
| @@ -33,6 +34,8 @@ | |||
| """A number bigger than whatever will be manually typed. But not so insanely big not to fit in a native integer.""" | |||
| TaskId = tuple[Id, int] | |||
| """Unique identifier for executed tasks.""" | |||
| PLATFORM_FOLDER = "platform" | |||
There was a problem hiding this comment.
minor: I would prefer to call it PLATFORM_DIR or PLATFORM_DIRECTORY
There was a problem hiding this comment.
@hay-k is there a reason for that? I always used the two interchangeably...
(i.e. for me it's also fine your proposal, no problem with that)
There was a problem hiding this comment.
@alecandido yeah, I myself use them interchangeably as well, especially when speaking. In code like this, I prefer to use dir/directory because it is the strict file system terminology. Folder seems to be more like a concept popularized by Microsoft Windows, is not necessarily a file system directory, and has some graphical/UI related connotations attached to it.
Closes #709.
A
platformfolder will now appear under eachprotocolfolder in the report.I've also made tests a bit more robust by checking if certain files/folders are present.
Checklist:
mastermainmain