Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in bootstrap.py and standard_rb.py #718

Merged
merged 21 commits into from
Feb 28, 2024

Conversation

Jacfomg
Copy link
Contributor

@Jacfomg Jacfomg commented Feb 16, 2024

Fixes the gate dict and [wip] error bars

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.
  • Compatibility with Qibo modules (Please edit this section if the current pull request is not compatible with the following branches).
    • Qibo: master
    • Qibolab: main
    • Qibolab_platforms_qrc: main

@andrea-pasquale
Copy link
Contributor

Is it ready to review?

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (fix-std-RB@4451721). Click here to learn what that means.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             fix-std-RB     #718   +/-   ##
=============================================
  Coverage              ?   96.92%           
=============================================
  Files                 ?      107           
  Lines                 ?     7580           
  Branches              ?        0           
=============================================
  Hits                  ?     7347           
  Misses                ?      233           
  Partials              ?        0           
Flag Coverage Δ
unittests 96.92% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/qibocal/bootstrap.py 47.36% <100.00%> (ø)
...haracterization/randomized_benchmarking/fitting.py 93.65% <ø> (ø)
...cterization/randomized_benchmarking/standard_rb.py 95.88% <100.00%> (ø)
.../characterization/randomized_benchmarking/utils.py 100.00% <ø> (ø)

@Jacfomg
Copy link
Contributor Author

Jacfomg commented Feb 16, 2024

Is it ready to review?

Not yet, I would like to implement properly the #712 or someone could start it from here

@Jacfomg Jacfomg marked this pull request as ready for review February 16, 2024 13:05
@andrea-pasquale andrea-pasquale marked this pull request as draft February 16, 2024 13:24
@Jacfomg Jacfomg marked this pull request as ready for review February 19, 2024 15:32
@Jacfomg
Copy link
Contributor Author

Jacfomg commented Feb 19, 2024

I found another issue that for multi qubit we would generate one circuit per qubit as run them separately, we should create an option to choose between that or parallel circuits in another PR. From this, results seem to be more sensible now, without bootstrapping as it seems like I broke it.

@Jacfomg Jacfomg marked this pull request as draft February 19, 2024 15:42
@Jacfomg Jacfomg marked this pull request as ready for review February 28, 2024 05:33
@Jacfomg
Copy link
Contributor Author

Jacfomg commented Feb 28, 2024

Looks good to me @Edoardo-Pedicillo

This was referenced Feb 28, 2024
@Jacfomg
Copy link
Contributor Author

Jacfomg commented Feb 28, 2024

Let's merge this into #597 and run it on hardware or ask for further reviews there

@andrea-pasquale andrea-pasquale merged commit 6aad68b into fix-std-RB Feb 28, 2024
21 checks passed
@andrea-pasquale andrea-pasquale deleted the fix-error_bars branch February 28, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clifford single qubit gates with determinant != 1
3 participants