-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error in bootstrap.py and standard_rb.py #718
Conversation
Is it ready to review? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## fix-std-RB #718 +/- ##
=============================================
Coverage ? 96.92%
=============================================
Files ? 107
Lines ? 7580
Branches ? 0
=============================================
Hits ? 7347
Misses ? 233
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Not yet, I would like to implement properly the #712 or someone could start it from here |
I found another issue that for multi qubit we would generate one circuit per qubit as run them separately, we should create an option to choose between that or parallel circuits in another PR. From this, results seem to be more sensible now, without bootstrapping as it seems like I broke it. |
src/qibocal/protocols/characterization/randomized_benchmarking/standard_rb.py
Outdated
Show resolved
Hide resolved
Looks good to me @Edoardo-Pedicillo |
Let's merge this into #597 and run it on hardware or ask for further reviews there |
Fixes the gate dict and [wip] error bars
Checklist:
master
main
main