Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for sequence unrolling in flipping and flipping_signal #720

Merged
merged 3 commits into from
Feb 21, 2024

Conversation

Jacfomg
Copy link
Contributor

@Jacfomg Jacfomg commented Feb 19, 2024

It adds support for sequence unrolling in flipping and flipping_signal as requested in qiboteam/qibolab_platforms_qrc#119. It has only been tested with dummy.

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.
  • Compatibility with Qibo modules (Please edit this section if the current pull request is not compatible with the following branches).
    • Qibo: master
    • Qibolab: main
    • Qibolab_platforms_qrc: main

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b11efdd) 97.23% compared to head (b4a1dc4) 97.24%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #720      +/-   ##
==========================================
+ Coverage   97.23%   97.24%   +0.01%     
==========================================
  Files         110      110              
  Lines        7618     7646      +28     
==========================================
+ Hits         7407     7435      +28     
  Misses        211      211              
Flag Coverage Δ
unittests 97.24% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/qibocal/protocols/characterization/flipping.py 96.89% <100.00%> (+0.43%) ⬆️
...ocal/protocols/characterization/flipping_signal.py 97.32% <100.00%> (+0.32%) ⬆️
src/qibocal/protocols/characterization/ramsey.py 100.00% <ø> (ø)

@andrea-pasquale andrea-pasquale linked an issue Feb 20, 2024 that may be closed by this pull request
Copy link
Contributor

@igres26 igres26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work as expected in the tries made with quantum machines. Albeit the speed-up in that case is not very significant, it is still there.

Copy link
Contributor

@andrea-pasquale andrea-pasquale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not tested the PR on hardware, but the code seems to be fine.

@andrea-pasquale
Copy link
Contributor

andrea-pasquale commented Feb 20, 2024

Maybe one quick thing, could you add also tests with the option unrolling=True?
If you do also coverage should pass.

@andrea-pasquale andrea-pasquale added this to the Qibocal 0.0.8 milestone Feb 21, 2024
@andrea-pasquale andrea-pasquale added this pull request to the merge queue Feb 21, 2024
Merged via the queue into main with commit ff4e2f5 Feb 21, 2024
21 checks passed
@andrea-pasquale andrea-pasquale deleted the flipping_unrolling branch February 21, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for unrolling in flipping protocol
3 participants