Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RB fix U3 #730

Merged
merged 1 commit into from
Feb 27, 2024
Merged

RB fix U3 #730

merged 1 commit into from
Feb 27, 2024

Conversation

Jacfomg
Copy link
Contributor

@Jacfomg Jacfomg commented Feb 27, 2024

Fixes an issue regarding how Qibo handles U3 parameters for the RB

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.
  • Compatibility with Qibo modules (Please edit this section if the current pull request is not compatible with the following branches).
    • Qibo: master
    • Qibolab: main
    • Qibolab_platforms_qrc: main

Copy link
Contributor

@igres26 igres26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should fix the issue.

KEEP IN MIND that this is a small patch, and that we should also look into the real issue in the u3 decomposition formula so that it takes into account the determinant of the gate it is trying to decompose.

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.15%. Comparing base (1ff6329) to head (7d33c5a).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #730      +/-   ##
==========================================
- Coverage   97.19%   97.15%   -0.04%     
==========================================
  Files         108      108              
  Lines        7601     7601              
==========================================
- Hits         7388     7385       -3     
- Misses        213      216       +3     
Flag Coverage Δ
unittests 97.15% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../characterization/randomized_benchmarking/utils.py 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

@andrea-pasquale andrea-pasquale added this pull request to the merge queue Feb 27, 2024
Merged via the queue into main with commit c7a43be Feb 27, 2024
21 checks passed
@andrea-pasquale andrea-pasquale deleted the RB_fix_U3 branch February 27, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants