fix: Added json extension to results for singleshot classification

[GabrielePalazzo]

Closes #746.

Checklist:

• Reviewers confirm new code works as expected.
• Tests are passing.
• Coverage does not decrease.
• Documentation is updated.
• Compatibility with Qibo modules (Please edit this section if the current pull request is not compatible with the following branches).
  • Qibo: master
  • Qibolab: main
  • Qibolab_platforms_qrc: main

[andrea-pasquale]

Thanks @GabrielePalazzo, do you know why tests are failing?

The problem was related to this line:

qibocal/src/qibocal/protocols/characterization/classification.py

Line 127 in ddba2d3

(path / RESULTSFILE).write_text(json.dumps(serialize(asdict_class)))

An alternative solution would be to add .json directly in this line.
Maybe it is better to put the extension directly in the top-level-constant.
I believe that tests should pass if you do so.

Let me know what you think.

[GabrielePalazzo]

If I revert this line, tests are passing.

qibocal/src/qibocal/auto/operation.py

Line 136 in e3737a3

(path / f"{filename}").write_text(

The cause is here (when we read json):

qibocal/src/qibocal/auto/operation.py

Line 169 in e3737a3

file = path / f"{filename}.json"

I think the safest approach is what you suggested (explicitly adding .json in singleshot), considering that, for example, DATAFILE cannot have its extension (it can be both json and npz).
What do you think?

[andrea-pasquale]

If I revert this line, tests are passing.

qibocal/src/qibocal/auto/operation.py

Line 136 in e3737a3

(path / f"{filename}").write_text(

The cause is here (when we read json):

qibocal/src/qibocal/auto/operation.py

Line 169 in e3737a3

file = path / f"{filename}.json"

I think the safest approach is what you suggested (explicitly adding .json in singleshot), considering that, for example, DATAFILE cannot have its extension (it can be both json and npz).
What do you think?

Sure, let's add .json in singleshot I forgot to update it when we refactored the data structure in #690.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.44%. Comparing base (ddba2d3) to head (8e73b6c).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #747   +/-   ##
=======================================
  Coverage   96.44%   96.44%           
=======================================
  Files         108      108           
  Lines        7509     7509           
=======================================
  Hits         7242     7242           
  Misses        267      267           

Flag	Coverage Δ
unittests	96.44% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...bocal/protocols/characterization/classification.py	100.00% <100.00%> (ø)

[andrea-pasquale]

Thanks @GabrielePalazzo