-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify different directory for qq fit
#774
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #774 +/- ##
==========================================
+ Coverage 97.20% 97.26% +0.06%
==========================================
Files 102 102
Lines 7301 7322 +21
==========================================
+ Hits 7097 7122 +25
+ Misses 204 200 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Co-authored-by: Gabriele Palazzo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from https://github.com/qiboteam/qibocal/pull/774/files#r1544149133, it looks good to me.
Co-authored-by: Gabriele Palazzo <[email protected]>
for more information, see https://pre-commit.ci
Thanks @GabrielePalazzo. I saw the comment after asking you for the second review :) |
I haven't checked if |
Closes #773
Checklist:
master
main
main