Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify different directory for qq fit #774

Merged
merged 8 commits into from
Mar 29, 2024
Merged

Specify different directory for qq fit #774

merged 8 commits into from
Mar 29, 2024

Conversation

andrea-pasquale
Copy link
Contributor

@andrea-pasquale andrea-pasquale commented Mar 28, 2024

Closes #773

  • Add tests

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.
  • Compatibility with Qibo modules (Please edit this section if the current pull request is not compatible with the following branches).
    • Qibo: master
    • Qibolab: main
    • Qibolab_platforms_qrc: main

@andrea-pasquale andrea-pasquale added the enhancement New feature or request label Mar 28, 2024
@andrea-pasquale andrea-pasquale self-assigned this Mar 28, 2024
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.26%. Comparing base (4a116d3) to head (2544043).
Report is 105 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #774      +/-   ##
==========================================
+ Coverage   97.20%   97.26%   +0.06%     
==========================================
  Files         102      102              
  Lines        7301     7322      +21     
==========================================
+ Hits         7097     7122      +25     
+ Misses        204      200       -4     
Flag Coverage Δ
unittests 97.26% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/qibocal/cli/_base.py 98.24% <100.00%> (+0.06%) ⬆️
src/qibocal/cli/fit.py 100.00% <100.00%> (ø)
src/qibocal/cli/report.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@andrea-pasquale andrea-pasquale marked this pull request as ready for review March 28, 2024 08:06
src/qibocal/cli/fit.py Outdated Show resolved Hide resolved
tests/test_cli.py Outdated Show resolved Hide resolved
Copy link
Contributor

@GabrielePalazzo GabrielePalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrea-pasquale
Copy link
Contributor Author

Apart from https://github.com/qiboteam/qibocal/pull/774/files#r1544149133, it looks good to me.

Thanks @GabrielePalazzo. I saw the comment after asking you for the second review :)

@GabrielePalazzo
Copy link
Contributor

Apart from https://github.com/qiboteam/qibocal/pull/774/files#r1544149133, it looks good to me.

Thanks @GabrielePalazzo. I saw the comment after asking you for the second review :)

I haven't checked if pathlib is imported.

@Edoardo-Pedicillo Edoardo-Pedicillo added this pull request to the merge queue Mar 29, 2024
Merged via the queue into main with commit 8f21e74 Mar 29, 2024
21 checks passed
@Edoardo-Pedicillo Edoardo-Pedicillo deleted the folder_qq branch March 29, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide folder for qq fit
3 participants