Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show end time correctly in HTML report #795

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Conversation

andrea-pasquale
Copy link
Contributor

@andrea-pasquale andrea-pasquale commented Apr 12, 2024

Currently in the report start time and end time were the same due to a small bug.
This PR fixes the issue.

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.
  • Compatibility with Qibo modules (Please edit this section if the current pull request is not compatible with the following branches).
    • Qibo: master
    • Qibolab: main
    • Qibolab_platforms_qrc: main

@andrea-pasquale andrea-pasquale added the bug Something isn't working label Apr 12, 2024
@andrea-pasquale andrea-pasquale added this to the Qibocal 0.0.9 milestone Apr 12, 2024
@andrea-pasquale andrea-pasquale self-assigned this Apr 12, 2024
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.19%. Comparing base (808e23f) to head (954a7d8).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #795   +/-   ##
=======================================
  Coverage   97.19%   97.19%           
=======================================
  Files         104      104           
  Lines        7567     7567           
=======================================
  Hits         7355     7355           
  Misses        212      212           
Flag Coverage Δ
unittests 97.19% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/qibocal/cli/autocalibration.py 100.00% <100.00%> (ø)

@andrea-pasquale andrea-pasquale added this pull request to the merge queue Apr 16, 2024
Merged via the queue into main with commit 7734577 Apr 16, 2024
21 checks passed
@andrea-pasquale andrea-pasquale deleted the correct_end_time branch April 16, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants