Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove frequency conversion in resonator frequency #855

Merged
merged 3 commits into from
Jun 12, 2024

Conversation

Edoardo-Pedicillo
Copy link
Contributor

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.
  • Compatibility with Qibo modules (Please edit this section if the current pull request is not compatible with the following branches).
    • Qibo: master
    • Qibolab: main
    • Qibolab_platforms_qrc: main

@Edoardo-Pedicillo Edoardo-Pedicillo changed the title Remove frequency conversion in flipping Remove frequency conversion in resonator frequency May 16, 2024
Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.32%. Comparing base (fa7e816) to head (e488b92).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #855   +/-   ##
=======================================
  Coverage   97.32%   97.32%           
=======================================
  Files         115      115           
  Lines        8645     8645           
=======================================
  Hits         8414     8414           
  Misses        231      231           
Flag Coverage Δ
unittests 97.32% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...tocols/readout_optimization/resonator_frequency.py 99.00% <100.00%> (ø)

@andrea-pasquale andrea-pasquale marked this pull request as ready for review June 10, 2024 08:41
@Edoardo-Pedicillo Edoardo-Pedicillo added this pull request to the merge queue Jun 12, 2024
Merged via the queue into main with commit a10e665 Jun 12, 2024
21 checks passed
@Edoardo-Pedicillo Edoardo-Pedicillo deleted the fix_flipping branch June 12, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants