Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper import for defaultdict #858

Merged
merged 1 commit into from
May 17, 2024
Merged

Proper import for defaultdict #858

merged 1 commit into from
May 17, 2024

Conversation

Jacfomg
Copy link
Contributor

@Jacfomg Jacfomg commented May 17, 2024

Proper import for defaultdict

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.
  • Compatibility with Qibo modules (Please edit this section if the current pull request is not compatible with the following branches).
    • Qibo: master
    • Qibolab: main
    • Qibolab_platforms_qrc: main

Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.28%. Comparing base (37d0605) to head (8dba04e).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #858      +/-   ##
==========================================
+ Coverage   97.24%   97.28%   +0.03%     
==========================================
  Files         107      107              
  Lines        7915     7915              
==========================================
+ Hits         7697     7700       +3     
+ Misses        218      215       -3     
Flag Coverage Δ
unittests 97.28% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...qibocal/protocols/randomized_benchmarking/utils.py 99.18% <100.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Member

@alecandido alecandido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Jacfomg

@stavros11 is just a hotfix, we could/should merge immediately :)

@alecandido
Copy link
Member

@stavros11 is just a hotfix, we could/should merge immediately :)

Sorry, I actually read them in inverse order, and I didn't notice this was coming from qiboteam/qibolab#903 (comment)

Thanks both for spotting and fixing.

@alecandido alecandido added this pull request to the merge queue May 17, 2024
Merged via the queue into main with commit 4c23ced May 17, 2024
21 checks passed
@alecandido alecandido deleted the fix_import branch May 17, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants