Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper name for fit functions #875

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Proper name for fit functions #875

merged 1 commit into from
Jun 11, 2024

Conversation

andrea-pasquale
Copy link
Contributor

Closes #393

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.
  • Compatibility with Qibo modules (Please edit this section if the current pull request is not compatible with the following branches).
    • Qibo: master
    • Qibolab: main
    • Qibolab_platforms_qrc: main

Copy link

codecov bot commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.36%. Comparing base (b0c0ef7) to head (7f83710).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #875      +/-   ##
==========================================
- Coverage   97.40%   97.36%   -0.05%     
==========================================
  Files         115      115              
  Lines        8645     8645              
==========================================
- Hits         8421     8417       -4     
- Misses        224      228       +4     
Flag Coverage Δ
unittests 97.36% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...cal/protocols/two_qubit_interaction/cz_virtualz.py 93.91% <100.00%> (ø)

... and 2 files with indirect coverage changes

@andrea-pasquale andrea-pasquale added this pull request to the merge queue Jun 11, 2024
Merged via the queue into main with commit 4c51ecd Jun 11, 2024
21 checks passed
@andrea-pasquale andrea-pasquale deleted the proper_fit_name branch June 11, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use proper names for fitting functions
3 participants