Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unify execution pars for dispersive shift #892

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

rodolfocarobene
Copy link
Contributor

Closes #887, but does not take care at all of #890.

How could we use params.execution_parameters and also pass standard values?

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.
  • Compatibility with Qibo modules (Please edit this section if the current pull request is not compatible with the following branches).
    • Qibo: master
    • Qibolab: main
    • Qibolab_platforms_qrc: main

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.44%. Comparing base (d209e87) to head (1ba3b8b).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #892   +/-   ##
=======================================
  Coverage   97.44%   97.44%           
=======================================
  Files         115      115           
  Lines        8684     8685    +1     
=======================================
+ Hits         8462     8463    +1     
  Misses        222      222           
Flag Coverage Δ
unittests 97.44% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/qibocal/protocols/dispersive_shift.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@alecandido
Copy link
Member

Closes #887, but does not take care at all of #890.

That's fine, one issue at a time. #890 is for the longer term

How could we use params.execution_parameters and also pass standard values?

We extend the routine object to contain an ExecutionParameters object, possibly with some fields set to None (that might require a mirror object, to possibly fix the attribute types with Optional), and the executor will inspect the routine attribute when determining which are the params.execution_parameters, setting them according to the following priority:

  • explicit routine parameters
  • explicit global parameters
  • routines default
  • global default

and that's what the routine should get access to in the params.execution_parameters. But it has to be implemented at the level of the execution, not the individual routine.

Copy link
Contributor

@andrea-pasquale andrea-pasquale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrea-pasquale
Copy link
Contributor

How could we use params.execution_parameters and also pass standard values?

As @alecandido suggested, we can take care of ExecutionParameters in a separate PR.

@rodolfocarobene rodolfocarobene added this pull request to the merge queue Jun 19, 2024
Merged via the queue into main with commit d358aa2 Jun 19, 2024
21 checks passed
@rodolfocarobene rodolfocarobene deleted the fix_dispersive_shift_parameters branch June 19, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dispersive shift not working as expected
4 participants