-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Advanced example in doc #903
Conversation
I didn't suggest this before, since it will change again with #869. However, that change will be just an addition, so we should be able to keep the updated material that will be produced in this PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #903 +/- ##
==========================================
- Coverage 97.48% 97.42% -0.07%
==========================================
Files 116 116
Lines 8882 8882
==========================================
- Hits 8659 8653 -6
- Misses 223 229 +6
Flags with carried forward coverage won't be shown. Click here to find out more. |
Now everything should be working. I guess that there is no need to expand more since things will soon change with #869 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rodolfocarobene, LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still have to run, to confirm it is actually working, but just reading it looks good :)
Co-authored-by: Alessandro Candido <[email protected]>
Minor fixes to the documentation
@scarrazza after I merge this PR we can proceed with the release for qibocal. |
Closes #901 (work in progress for now)
Checklist:
master
main
main