Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Advanced example in doc #903

Merged
merged 12 commits into from
Jun 26, 2024
Merged

Fix Advanced example in doc #903

merged 12 commits into from
Jun 26, 2024

Conversation

rodolfocarobene
Copy link
Contributor

Closes #901 (work in progress for now)

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.
  • Compatibility with Qibo modules (Please edit this section if the current pull request is not compatible with the following branches).
    • Qibo: master
    • Qibolab: main
    • Qibolab_platforms_qrc: main

@alecandido
Copy link
Member

I didn't suggest this before, since it will change again with #869. However, that change will be just an addition, so we should be able to keep the updated material that will be produced in this PR.

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.42%. Comparing base (0625d90) to head (1305045).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #903      +/-   ##
==========================================
- Coverage   97.48%   97.42%   -0.07%     
==========================================
  Files         116      116              
  Lines        8882     8882              
==========================================
- Hits         8659     8653       -6     
- Misses        223      229       +6     
Flag Coverage Δ
unittests 97.42% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

@rodolfocarobene rodolfocarobene marked this pull request as ready for review June 25, 2024 12:08
@rodolfocarobene
Copy link
Contributor Author

Now everything should be working. I guess that there is no need to expand more since things will soon change with #869

@rodolfocarobene rodolfocarobene changed the title FiX Advanced example in doc Fix Advanced example in doc Jun 25, 2024
Copy link
Contributor

@andrea-pasquale andrea-pasquale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rodolfocarobene, LGTM.

doc/source/tutorials/advanced.rst Outdated Show resolved Hide resolved
Copy link
Member

@alecandido alecandido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still have to run, to confirm it is actually working, but just reading it looks good :)

doc/source/tutorials/advanced.rst Outdated Show resolved Hide resolved
doc/source/tutorials/advanced.rst Outdated Show resolved Hide resolved
doc/source/tutorials/advanced.rst Outdated Show resolved Hide resolved
doc/source/tutorials/advanced.rst Outdated Show resolved Hide resolved
doc/source/tutorials/advanced.rst Outdated Show resolved Hide resolved
@andrea-pasquale
Copy link
Contributor

andrea-pasquale commented Jun 26, 2024

@scarrazza after I merge this PR we can proceed with the release for qibocal.

@andrea-pasquale andrea-pasquale added this pull request to the merge queue Jun 26, 2024
Merged via the queue into main with commit 95330b4 Jun 26, 2024
21 checks passed
@andrea-pasquale andrea-pasquale deleted the fix_library_tutorial branch June 26, 2024 13:07
@alecandido alecandido mentioned this pull request Jul 11, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Advanced example broken in documentation
3 participants