Fix classifiers plot #928
Merged
Fix classifiers plot #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #928 +/- ##
==========================================
+ Coverage 97.27% 97.55% +0.28%
==========================================
Files 118 118
Lines 9014 9016 +2
==========================================
+ Hits 8768 8796 +28
+ Misses 246 220 -26
Flags with carried forward coverage won't be shown. Click here to find out more.
|
alecandido
force-pushed
the
import-from-executor
branch
from
c642c29
to
24ce17b
Compare
alecandido
force-pushed
the
fix_classifiers_plot
branch
from
475b544
to
2c12830
Compare
Edoardo-Pedicillo
approved these changes
Jul 10, 2024
|
Let's merge this right after #869 :) |
Ok, then I'll add you as a reviewer as well since we will need two reviews. |
alecandido
approved these changes
Jul 10, 2024
alecandido
force-pushed
the
import-from-executor
branch
3 times, most recently
from
1eda603
to
39a3ba6
Compare
alecandido
force-pushed
the
fix_classifiers_plot
branch
from
2c12830
to
e1a7b57
Compare
|
@andrea-pasquale should we merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When plotting from file using
qq reportthe fit was never appearing for single shot classification.This PR fixes the issue.
@Edoardo-Pedicillo for the time being this is mostly a patch, if you have a better solution let me know
Checklist:
mastermainmain