Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop explicit setuptools dependency #931

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Conversation

alecandido
Copy link
Member

Since @rodolfocarobene's issue, plotly/dash#2557, we could finally drop this dependency.

I also took the chance to update the Plotly version.

@alecandido alecandido changed the title build: Drop explicit setuptools dependency Drop explicit setuptools dependency Jul 10, 2024
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.46%. Comparing base (321d9f3) to head (53a5502).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #931      +/-   ##
==========================================
- Coverage   97.52%   97.46%   -0.06%     
==========================================
  Files         117      117              
  Lines        8874     8874              
==========================================
- Hits         8654     8649       -5     
- Misses        220      225       +5     
Flag Coverage Δ
unittests 97.46% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@alecandido alecandido added this pull request to the merge queue Jul 10, 2024
Merged via the queue into main with commit 8a4505e Jul 10, 2024
21 checks passed
@alecandido alecandido deleted the drop-explicit-setuptools branch July 10, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants