Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing report generation after upload #935

Merged
merged 5 commits into from
Jul 18, 2024
Merged

Conversation

andrea-pasquale
Copy link
Contributor

Closes #934

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.
  • Compatibility with Qibo modules (Please edit this section if the current pull request is not compatible with the following branches).
    • Qibo: master
    • Qibolab: main
    • Qibolab_platforms_qrc: main

@andrea-pasquale andrea-pasquale added the bug Something isn't working label Jul 11, 2024
@andrea-pasquale andrea-pasquale self-assigned this Jul 11, 2024
Copy link

codecov bot commented Jul 11, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 97.57%. Comparing base (93d8908) to head (4246ec9).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #935      +/-   ##
==========================================
- Coverage   97.59%   97.57%   -0.03%     
==========================================
  Files         118      118              
  Lines        9016     9015       -1     
==========================================
- Hits         8799     8796       -3     
- Misses        217      219       +2     
Flag Coverage Δ
unittests 97.57% <42.85%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/qibocal/auto/output.py 100.00% <100.00%> (ø)
src/qibocal/cli/upload.py 33.33% <20.00%> (-0.76%) ⬇️

... and 1 file with indirect coverage changes

src/qibocal/auto/output.py Outdated Show resolved Hide resolved
src/qibocal/auto/output.py Outdated Show resolved Hide resolved
src/qibocal/cli/upload.py Show resolved Hide resolved
@andrea-pasquale andrea-pasquale added this pull request to the merge queue Jul 18, 2024
Merged via the queue into main with commit c2e0ca1 Jul 18, 2024
20 of 21 checks passed
@andrea-pasquale andrea-pasquale deleted the fix_meta_upload branch July 18, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running qq report after qq upload fails
3 participants