Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set platform in RB backend #941

Merged
merged 2 commits into from
Jul 19, 2024
Merged

Set platform in RB backend #941

merged 2 commits into from
Jul 19, 2024

Conversation

alecandido
Copy link
Member

This is a rough patch for the problem found in qiboteam/qibolab_platforms_qrc#151 (comment)

A better solution is postponed to a different version of Qibolab/Qibocal.

Copy link
Contributor

@andrea-pasquale andrea-pasquale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alecandido, it works for me.
Btw, there are other protocols which are using GlobalBackend. I can push directly here the changes or open a new PR adding the same modification for those protocols.

@alecandido
Copy link
Member Author

alecandido commented Jul 19, 2024

Btw, there are other protocols which are using GlobalBackend. I can push directly here the changes or open a new PR adding the same modification for those protocols.

@andrea-pasquale feel free to push changes, if you wish.
The scope is meaningful, and the PR is definitely not big already.

@andrea-pasquale
Copy link
Contributor

Btw, there are other protocols which are using GlobalBackend. I can push directly here the changes or open a new PR adding the same modification for those protocols.

@andrea-pasquale feel free to push changes, if you wish. The scope is meaningful, and the PR is definitely not big already.

I've pushed the changes here #943

@alecandido
Copy link
Member Author

I've pushed the changes here #943

Then I'm merging this (it's still in another PR, and it will be needed to make that work)

@alecandido alecandido merged commit 1e1fd93 into fix_padding Jul 19, 2024
10 of 19 checks passed
@alecandido alecandido deleted the rb-set-platform branch July 19, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants