Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Executor context manager #949

Merged
merged 12 commits into from
Aug 13, 2024
Merged

Executor context manager #949

merged 12 commits into from
Aug 13, 2024

Conversation

alecandido
Copy link
Member

This is more or less complete as it is.

I will test, but it is already doing little to nothing.

Since this was originally an idea by @andrea-pasquale, I'd say it is ready for your review in the first place, and I'd like to collect your feedback.

Copy link

codecov bot commented Jul 28, 2024

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.46%. Comparing base (b1079b1) to head (970776b).

Files Patch % Lines
src/qibocal/auto/execute.py 94.11% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #949      +/-   ##
==========================================
- Coverage   97.46%   97.46%   -0.01%     
==========================================
  Files         120      120              
  Lines        9477     9494      +17     
==========================================
+ Hits         9237     9253      +16     
- Misses        240      241       +1     
Flag Coverage Δ
unittests 97.46% <94.11%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/qibocal/auto/execute.py 97.67% <94.11%> (-0.54%) ⬇️

Base automatically changed from exec-ops to main July 29, 2024 10:38
@alecandido alecandido mentioned this pull request Jul 29, 2024
8 tasks
Copy link
Contributor

@andrea-pasquale andrea-pasquale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alecandido, LGTM.
I will test it shortly.
There is one thing still to be addressed after #942:
#942 (comment).
I think that we should expose also the update attribute. If we don't it will be set to True and all checks that we are performing in https://github.com/qiboteam/qibocal/blob/exec-ctx-manager/runcards/rx_calibration.py to assess when to update the platform don't make much sense. Let me know what you think.

@alecandido
Copy link
Member Author

There is one thing still to be addressed after #942:
#942 (comment).

Sorry, I've been too fast to merge that. But they are all additions, I will provide them here.

@alecandido alecandido mentioned this pull request Jul 30, 2024
1 task
@Jacfomg Jacfomg mentioned this pull request Jul 30, 2024
8 tasks
@andrea-pasquale andrea-pasquale mentioned this pull request Aug 1, 2024
8 tasks
Copy link
Contributor

@andrea-pasquale andrea-pasquale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alecandido, works for me. Just a tiny comment.

runcards/rx_calibration.py Show resolved Hide resolved
@alecandido
Copy link
Member Author

Ok, tests are definitely not extensive, and they should be improved.

However, the feature is there, and minimally tested. Since there are already other PRs relying on this, let's merge as soon as @Jacfomg confirms it is fine :)

@alecandido alecandido linked an issue Aug 13, 2024 that may be closed by this pull request
@alecandido alecandido added this pull request to the merge queue Aug 13, 2024
Merged via the queue into main with commit d5c0f2d Aug 13, 2024
19 checks passed
@alecandido alecandido deleted the exec-ctx-manager branch August 13, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

close method of executor does not dump updated platform
3 participants