Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates in Cross Resonance calibration routines #987

Open
wants to merge 7 commits into
base: cross_resonance
Choose a base branch
from

Conversation

jevillegasdatTII
Copy link

Follow up on #821 and PR #860

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.
  • Compatibility with Qibo modules (Please edit this section if the current pull request is not compatible with the following branches).
    • Qibo: master
    • Qibolab: main
    • Qibolab_platforms_qrc: main

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 54.43548% with 113 lines in your changes missing coverage. Please review.

Project coverage is 96.02%. Comparing base (7a7c18e) to head (1da4d51).
Report is 672 commits behind head on cross_resonance.

Files with missing lines Patch % Lines
...t_interaction/cross_resonance/chevron_frequency.py 49.45% 46 Missing ⚠️
...ction/cross_resonance/cross_resonance_sequences.py 39.13% 42 Missing ⚠️
...ols/two_qubit_interaction/cross_resonance/utils.py 0.00% 25 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##           cross_resonance     #987      +/-   ##
===================================================
- Coverage            97.30%   96.02%   -1.28%     
===================================================
  Files                  112      115       +3     
  Lines                 8194     8402     +208     
===================================================
+ Hits                  7973     8068      +95     
- Misses                 221      334     +113     
Flag Coverage Δ
unittests 96.02% <54.43%> (-1.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/qibocal/protocols/__init__.py 100.00% <100.00%> (ø)
...ibocal/protocols/two_qubit_interaction/__init__.py 100.00% <100.00%> (ø)
...protocols/two_qubit_interaction/chevron/chevron.py 96.87% <ø> (ø)
.../two_qubit_interaction/cross_resonance/__init__.py 100.00% <100.00%> (ø)
...s/two_qubit_interaction/cross_resonance/chevron.py 100.00% <100.00%> (ø)
...bit_interaction/cross_resonance/cross_resonance.py 100.00% <100.00%> (ø)
...ols/two_qubit_interaction/cross_resonance/utils.py 0.00% <0.00%> (ø)
...ction/cross_resonance/cross_resonance_sequences.py 39.13% <39.13%> (ø)
...t_interaction/cross_resonance/chevron_frequency.py 49.45% <49.45%> (ø)

@jevillegasdatTII
Copy link
Author

In none of the routines using sweepers, the readout pulse is swept at the same as the CR drive pulse duration, similar to what was discussed in #qiboab/919. I'm not sure how can I do this correctly, but since the typical tests I was running re ~400 ns, this wasn't a problem yet.

@alecandido
Copy link
Member

@jevillegasdatTII there is an ongoing PR, qiboteam/qibolab#993, realized by @hay-k, which is restoring some expected Qblox behavior on top of a Qibolab version compatible with the current Qibocal.

Did you try the corresponding branch https://github.com/qiboteam/qibolab/tree/qblox-ad-hoc-features?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants