Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve update method for AbstractPlatform #418

Closed
andrea-pasquale opened this issue May 17, 2023 · 0 comments · Fixed by #596
Closed

Improve update method for AbstractPlatform #418

andrea-pasquale opened this issue May 17, 2023 · 0 comments · Fixed by #596

Comments

@andrea-pasquale
Copy link
Contributor

The implementation of the update could be improved given that currently we check manually for every single entry in the dictionary which passed to the method.
It would be nice to move to something simpler as noted by @stavros11 here.
I think that using a DesignPlatform with the refactor of the AbstractPlatform in #387. This should be quite easy to do.
However, as long as we have also the Multiqubit platform we need to provide a way to make this update work also for this platform. Although it will be preferable to move also qblox to the DesignPlatform asap.

Morever, we should increase the coverage of the update method.

@andrea-pasquale andrea-pasquale linked a pull request Sep 26, 2023 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant